NASA-AMMOS / NASA-AMMOS/plandev

Plans containing activities that fail their validation method should not simulate

Open
#762 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

clipper
Dominant language
Java
Stars
128
Forks
33
Avg merge
1d 17h
Merged PRs (30d)
12

Description

amgreer
https://jira.jpl.nasa.gov/browse/AERIEQS-429
Moderate
Using aerie 13.2 we are noticing that plans which contain invalid parameters are completing simulations rather than failing. For instance, the default value of SUDA_Decontamination has an invalid duration of 6 seconds for deconDuration. This is an error in the activity itself, however, it should be caught by aerie and prevent a simulation from occurring. A screenshot of the error is attached below.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the aerie 13.2 case with a plan containing the invalid SUDA_Decontamination deconDuration value. Trace activity validation and the simulation entry point to determine why validation does not block simulation. Done means plans with activities that fail their validation method are rejected before simulation begins.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.