NASA-AMMOS / NASA-AMMOS/plandev
Refactor sequencing server tests
Open
Nobody has claimed this yet.
sequencing
test
- Dominant language
- Java
- Stars
- 128
- Forks
- 33
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 12
Description
When writing tests for https://github.com/NASA-AMMOS/aerie/pull/725, we uncovered a few issues with the sequencing server tests that we would like to address here:
- Update the simulation action to subscribe instead of busy wait. This should be even better after https://github.com/NASA-AMMOS/aerie/issues/730.
- Do a pass over all tests to make sure we are cleaning up properly.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the sequencing server tests and the simulation action referenced in this issue, then review pull request 725 and issue 730 for context. Done means the simulation action uses subscription rather than busy waiting and the test suite consistently cleans up its resources.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100