Editing parcel parameter dictionaries gets DB in a weird state

Checked for duplicates

No - I haven't checked

Is this a regression?

No - This is a new bug

Version

3.0.1, 3.4.0

Describe the bug

When editing the parameter dictionaries in a parcel, and particularly when trying to add multiple parameter dictionaries, we managed to get the DB into a weird state where the parameter dictionaries are repeatedly specified in the parcel:

  {
    "name": "parcel name",
    "command_dictionary_id": 5,
    "channel_dictionary_id": 2,
    "sequence_adaptation_id": 34,
    "parameter_dictionary_ids": [
      2,
      2,
      67,
      2,
      67,
      2,
      67
    ],
    "id": 103
  }

On the plus side, it doesn't seem to impact usability (as long as you want those two parameter dictionaries).

Reproduction

Repro'd with Aerie v3.4.0 locally:

• Upload multiple parameter dictionaries (TBR whether this is necessary, or whether we get this behavior with just one)
• Add the parameter dictionaries to a new parcel
• Create another parcel, adding the same two parameter dictionaries
• The DB at this point (I think) has some duplicate entries in parcel_to_parameter_dictionary
• Go back to the first parcel. The UI shows neither parameter dictionary selected.
• Re-select the two parameter dictionaries and save. The DB now has more duplicate entries in parcel_to_parameter_dictionary

Logs

System Info

Clipper Aerie on AWS

Severity

Minor

Start by reproducing the parcel-editing sequence described in the issue, then inspect how parcel_to_parameter_dictionary entries are created and how the UI loads selected parameter dictionaries. Done means saving parcels no longer creates duplicate associations and reopening the first parcel shows its selected dictionaries consistently.