NASA-AMMOS / NASA-AMMOS/plandev

Revisit Sequence Templates arguments reformattting

Open
#1,676 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature
Dominant language
Java
Stars
128
Forks
33
Avg merge
1d 17h
Merged PRs (30d)
12

Description

Checked for duplicates

No - I haven't checked

Alternatives considered

No - I haven't considered

Related problems

Right now, the arguments and computed attributes that get passed to sequence template expansion are all stringified:

https://github.com/NASA-AMMOS/aerie/blob/03df8fd53f63aba2a41430468fe4f06018b33269/sequencing-server/src/lib/mustache/util/activity.ts#L4-L20

This makes it impossible to, e.g., iterate over arrays/objects.

Describe the feature request

Remove this and, if some amount of stringification is necessary, make it smarter so as to not stringify arrays/objects.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with sequencing-server/src/lib/mustache/util/activity.ts, especially lines 4–20, to trace how arguments and computed attributes are converted before sequence template expansion. Check the existing sequence-template behavior and determine which values must retain array or object structure. Done means templates can iterate over arrays and objects without unnecessary stringification, while any required string conversion still behaves correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.