NASA-AMMOS / NASA-AMMOS/plandev
Clean up sequence server routes
Open
Nobody has claimed this yet.
refactor
- Dominant language
- Java
- Stars
- 128
- Forks
- 33
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 12
Description
Clean up the sequencing server's routes/seqjson.ts and routes/command-expansion.ts:
- Consolidate shared logic for invoking builders (lots of re-generating
sortedSimulatedActivitiesWithCommands) - Reduce duplicate simulated activity fetches
- Remove use of
nullforexpansionResultsto simplify processing those results - Remove the long deprecated route
/get-seqjson-for-seqid-and-simulation-dataset?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading routes/seqjson.ts and routes/command-expansion.ts, focusing on builder invocation and the repeated simulated-activity fetches. Trace how expansionResults and the deprecated /get-seqjson-for-seqid-and-simulation-dataset route are used; done means shared logic is consolidated, duplicate fetches are reduced, null handling is removed, and the deprecated route is addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api, backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100