NASA-AMMOS / NASA-AMMOS/plandev-ui

Refactor to remove getSequenceSeqJson in favor of expanded_sequences table

Open
#830 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

refactor
Dominant language
Svelte
Stars
42
Forks
14
Avg merge
1d 16h
Merged PRs (30d)
10

Description

Now that we have the expanded_sequences table, we no longer need to call the getSequenceSeqJson action to get the seq JSON in ExpansionSequenceModal.svelte. This is to refactor to use the expanded_sequences table to get the seq JSON instead.

This should also include updating ExpansionPanel.svelte to use expanded_sequences (joined with sequence) for consistency and simplicity.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading src/components/modals/ExpansionSequenceModal.svelte and src/components/expansion/ExpansionPanel.svelte, then trace how each currently calls getSequenceSeqJson and accesses sequence data. Update both components to use expanded_sequences, joining with sequence where needed. Done means neither component relies on getSequenceSeqJson and both obtain the sequence JSON through the expanded_sequences table.

Written by the indexing model from the issue text.

Assessment

Domain
frontend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.