NASA-AMMOS / NASA-AMMOS/MMTC

Consider alternative strategies for applying frame size validation during telemetry selection

Open
#113 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
8
Forks
4
PR merge metrics
No merged PRs in 30d

Description

Currently, TelemetrySelectionStrategy.ensureSamplesHaveDownlinkRate(List<FrameSample> samples) checks all samples retrieved from the telemetry source for consistent frame size bits values, not just the samples currently being considered in a candidate sample set/window. This presents problems for missions where short and long frames are frequently mixed in a 24h window, as MMTC will refuse to run even when VCID groups are correctly configured to distinguish short from long frames.

It might be preferable to only apply consistent frame size validation after the VCID filter has already been applied as to avoid tossing out whole frame sample sets that likely contain valid candidate subsets just because some frames in the query window aren't the same size.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with TelemetrySelectionStrategy.ensureSamplesHaveDownlinkRate(List samples) and trace how VCID filtering and candidate sample sets or windows are applied. Compare validation over all retrieved samples with validation after the VCID filter; done means mixed frame sizes no longer reject valid VCID-specific candidate sets while consistent-size validation remains.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.