[New Feature]: Validate fill types for clearOnMapClick
Open
Nobody has claimed this yet.
backlog
enhancement
- Dominant language
- JavaScript
- Stars
- 232
- Forks
- 77
- Avg merge
- 3d 6h
- Merged PRs (30d)
- 17
Description
Checked for duplicates
Yes - I've already checked
Alternatives considered
Yes - and alternatives don't suffice
Related problems
See comments in https://github.com/NASA-AMMOS/MMGIS/pull/348#pullrequestreview-1318703412.
Describe the feature request
There may be multiple ways a polygon gets no fill:
- "fillColor": "rgba(R,G,B,0)"
- "fillOpacity": 0
We should validate and test the different types of polygon fills with the clearOnMapClick function.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the clearOnMapClick function and any tests covering polygon fills. Check behavior for polygons using rgba(R,G,B,0) and fillOpacity: 0, then add validation tests that cover the supported no-fill cases and confirm clearOnMapClick handles them correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100