DCS Containers: $DISABLE_TLS not working correctly
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 5
- Forks
- 5
- Avg merge
- 6h 43m
- Merged PRs (30d)
- 5
Description
The startup scripts in the DCS Containers have unused code for importing TLS artifacts from a mounted directory that is not longer used, and do not handle the $DISABLE_TLS environment variable properly.
Simplify the scripts to remove unnecessary portions of TLS import code.
Should set a default of "false" for $DISABLE_TLS. If $DISABLE_TLS is true, then use ammos-truststore.jks instead of ammos-mtls-truststore.jks. Currently, ammos-mtls-truststore.jks is not imported if $DISABLE_TLS is true, but ammos-truststore.jks is not used instead.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the DCS Containers startup scripts and inspect the existing TLS artifact import logic and DISABLE_TLS handling. Verify the default behavior and the truststore selected for both true and false values. Done means unused mounted-directory import code is removed and the correct truststore is used in each mode.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, java
- Domain
- devops, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100