Sample PP JSON Parsing Fixes & Cleanup
Open
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 14
- Forks
- 9
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 33
Description
- Handle IV param in parsing (SamplePolicyConfigParser.c:442)
- Error check strtol (can add precondition check, or post-check
errno, or both) - validate
params_gotmatches what is expected/required after all JSON has been parsed (line 553) - better mem / lifetime management of InitParams to avoid copying
- add helpers to reduce cognitive complexity
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading SamplePolicyConfigParser.c around lines 442 and 553, then trace how InitParams and the parsed JSON values are handled. Done means IV parameters and required parameter counts are validated, strtol errors are checked, InitParams lifetime and copying are addressed, and parsing helpers reduce the stated complexity.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100