NASA-AMMOS / NASA-AMMOS/AIT-GUI
Update AIT-GUI for AIT-Core 3 / msgpack serialization
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 31
- Forks
- 15
- Avg merge
- 1m
- Merged PRs (30d)
- 1
Description
As part of https://github.com/NASA-AMMOS/AIT-Core/pull/542, pickle was replaced by msgpack for serialization.
During the pickle era, some messages were double-pickled (pickled prior to passing off the 0MQ where it would be pickled again). Plugin's would eventually receive a pickled-once message, and so would need to call pickle.loads() to recover.
With AIT-Core 3, the message passed to Plugin.process() is fully recovered. So we just need to ensure pickle.loads() is removed.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at ait/gui/init.py around line 352 and inspect how Plugin.process() handles messages after the AIT-Core 3 msgpack change. Remove the obsolete pickle deserialization and verify that plugins receive the fully recovered message without double deserialization.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 65/100