NASA-AMMOS / NASA-AMMOS/AIT-Core
Cmd validation ignores CCSDS app id when reporting duplicate op codes
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 56
- Forks
- 35
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 3
Description
The Cmd validation needs to consider the CCSDS support added in a previous ticket when reporting duplicate commands or opcodes.
Snippet from ticket where support was implemented is below. Changes were added in dac25002748f46a1ae58141e0e30a059b86283e1.
We need to elevate CCSDS header support in bliss.core to allow (optional) specification of CCSDS headers and expected values when defining telemetry packets:
- !Packet
name: EHS
desc: Engineering Health and Status
ccsds:
apid: 42
fields:
...
and commands:
- !Command
name: NO_OP
opcode: 0x00
ccsds: { apid: 0x06, type: 1, shflag: 1, seqflags: 0b11 }
subsystem: CORE
title: No Operation
desc: No Operation
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the command validation logic and the CCSDS support introduced in commit dac25002748f46a1ae58141e0e30a059b86283e1. Check how duplicate commands or opcodes are reported when commands have different CCSDS apids; done means duplicate validation accounts for the app id while preserving the existing command definitions shown in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100