NASA-AMMOS / NASA-AMMOS/AIT-Core
Config caching with msgpack migration
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 56
- Forks
- 35
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 3
Description
As part of the pickle security refactoring to use msgpack in place of pickle for serialization, config caching was removed which in-turn will cause performance regressions. Initial PR for pickle removal: here, note: check_yaml_timestamps was updated per the refactoring, however, dirty cache method was removed and therefore the check_yaml_timestamps method is no longer called.
I spoke to the previous developer (@nttoole) who mentioned this was done intentionally as there was documented issues with the caching implementation which some missions have tried to improve in their own adaptations. In the long term and outside of the scope of this issue, it would probably be best to reevaluate and improve caching.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the linked pickle-removal commit, then trace the current configuration caching flow around check_yaml_timestamps and the removed dirty cache method. Done means configuration caching is restored using msgpack without reintroducing the documented caching problems, and timestamp changes again trigger the intended cache behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100