NASA-AMMOS / NASA-AMMOS/AIT-Core
Multiple Local Code Executions (using Pickle)
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 56
- Forks
- 35
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 3
Description
AIT-Core extensively uses Pickle. As per Python documentation, this library is insecure and allows bad actors to achieve Command Execution. One example is loading a leap seconds configuration file, part of the DMC module. According to AIT-Core documentation, the ait.dmc module provides utilities to represent, translate, and manipulate time, building upon Python's datetime and timedelta data types. When the leapseconds.dat file is loaded, AIT-Core uses Pickle to process the file (see Figure 13).
Figure 13: AIT-Core processes the leapseconds.dat using Pickle.
If the bad actors can access the AIT-Core configuration file, they can change it to point to their malicious pickle file (see Figure 14), which will then be executed by the AIT-Core DMC module (see Figure 15).
Figure 14: Example of a malicious Pickle file.
Figure 15: AIT-Core DMC loads the malicious Pickle file.
Other areas where the pickle is used and can lead to Local Command Execution are the following modules:
- Table
- Util
- Data Archive
- Limit Monitor
- Open MCT Plugin
Recommendations
The pickle library is insecure and can lead to Command Execution vulnerabilities. Therefore, it should not be used, or the content of the loaded pickle files should be sanitised. This is just one example of how AIT-Core utilises the Pickle library, which we decided to use to demonstrate how it can be exploited.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by auditing Pickle usage in the DMC module and the named Table, Util, Data Archive, Limit Monitor, and Open MCT Plugin areas. Trace how leapseconds.dat and configured files are loaded, then determine a safe replacement or sanitization approach. Done means the identified loading paths no longer permit malicious local command execution.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- security
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100