NASA-AMMOS / NASA-AMMOS/AIT-Core

Outdated exception message handling

Open
#347 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
56
Forks
35
Avg merge
1d 20h
Merged PRs (30d)
3

Description

A user ran into an issue with a chunk of the CmdAPI exception handling code.

https://github.com/NASA-AMMOS/AIT-Core/blob/67e2682ceb8d725dda9120bff080e5c23598e6bc/ait/core/api.py#L226

            except socket.error as e:
                log.error(e.message)
            except IOError as e:
                log.error(e.message)

The .message attribute isn't a thing anymore and needs changed. It's likely there are other places in the code base where this is being done as well.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the exception handlers in ait/core/api.py at the linked location, then search the repository for other uses of the obsolete exception message access. Confirm the supported logging approach and update each affected occurrence; done means socket and I/O errors no longer rely on that attribute.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.