NASA-AMMOS / NASA-AMMOS/AIT-Core
readBinary() parsing order doesn't seems to be correct
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 56
- Forks
- 35
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 3
Description
seq.py#L194
Order of parsing doesn't seems to be correct. For testing purpose, code was updated as follows. Need a further investigation for the appropriate fix:
stream = open(filename, 'rb')
magic = struct.unpack('>H', stream.read(2))[0]
uploadtype = stream.read(1)
self.version = struct.unpack('B', stream.read(1))[0]
ncmds = struct.unpack('>H', stream.read(2))[0]
self.seqid = struct.unpack('>H', stream.read(2))[0]
reserved = stream.read(20)
self.crc32 = struct.unpack('>I', stream.read(4))[0]
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at ait/core/seq.py line 194 and inspect readBinary() alongside the binary field order shown in the issue. Trace how each stream.read() maps to the sequence format and determine the appropriate parsing order. Done means readBinary() correctly interprets the file header and sequence metadata without the temporary changes described.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100