NASA-AMMOS / NASA-AMMOS/AIT-Core

Gevent Monkey Patching issue with Requests

Open
#253 1 comment 0 reactions 1 assignee View on GitHub

@MJJoyce is already working on this.

Since Mar 25, 2020.

Dominant language
Python
Stars
56
Forks
35
Avg merge
1d 20h
Merged PRs (30d)
3

Description

In certain import or execution scenarios we can end up monkey patching ssl after it has already been imported. This can cause known issues in Python >= 3.6.

https://github.com/gevent/gevent/issues/1016

The GUI docs build seems to be running into this issue because the leapseconds.dat file needs fetch (which makes a request call). I can replicate this by deleting my local leapseconds.dat file and attempting to build the GUI docs.

We should move the monkey patch calls in Core and the other repos to address this.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.