NASA-AMMOS / NASA-AMMOS/AIT-Core

Config strftime expansions are always applied to paths

Open
#11 0 comments 0 reactions 1 assignee View on GitHub

@MJJoyce is already working on this.

Since Apr 12, 2018.

Dominant language
Python
Stars
56
Forks
35
Avg merge
1d 20h
Merged PRs (30d)
3

Description

Config file loading attempts to expand out all strftime format strings in paths. There's no way to turn this off at the moment for a given string/path.

The PCap rotation being used by #10 requires that a format string be passed to open() with strftime format strings so the log can be rotated. Currently this is using command.history.filename as the value but any strftime format strings in the name are expanded out on load. This results in all the logs being rotated to the same file name ...

We need to add a way to mark a string as not requiring the strftime expansion in the config file.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.