NASA-AMMOS / NASA-AMMOS/3DTilesRendererJS
TilesRenderer: Clean up disposal process
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2.5k
- Forks
- 416
- Avg merge
- 17h 52m
- Merged PRs (30d)
- 37
Description
Related to #877
- see if we can remove caching of materials, etc
- deduplicate code between the intermediate parseTile disposal and disposeTile disposal
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the related discussion in #877 and locating the intermediate parseTile disposal and disposeTile disposal paths. Compare their cleanup responsibilities and inspect how materials are cached. Done means the disposal process no longer duplicates logic and unnecessary caching has been removed, with existing behavior preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, three.js
- Domain
- computer-graphics
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100