NASA-AMMOS / NASA-AMMOS/3DTilesRendererJS
Reuse callback functions where possible
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2.5k
- Forks
- 416
- Avg merge
- 17h 52m
- Merged PRs (30d)
- 37
Description
New functions are created for queues, caches, and promises which will create a new function with a new scope. It's best to avoid though it might not be a huge deal because it's not necessarily happening every frame. Reference:
https://stackoverflow.com/a/7451336/9838891
Possible improvements:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the referenced callback sites in src/utilities/PriorityQueue.js and src/utilities/LRUCache.js, then inspect TilesRendererBase.requestTileContents in src/base/TilesRendererBase.js. Identify which callbacks are recreated in the listed ranges and determine where reuse is appropriate. Done means the applicable callback functions are reused without changing queue, cache, or promise behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- performance
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100