NASA-AMMOS / NASA-AMMOS/3DTilesRendererJS

LRUCache: Use a shared unload function

Open
#44 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
2.5k
Forks
416
Avg merge
17h 52m
Merged PRs (30d)
37

Description

Right now every tile gets its own function created but you should be able to set it per cache object:

const cache = new LRUCache();
cache.unloadCallback = tile => {
  
  // ...

};

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Start by locating the LRUCache implementation and the per-tile unload callback; done means the unload behavior can be assigned once on a cache object instead of creating a separate function for every tile.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
performance
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.