NASA-AMMOS / NASA-AMMOS/3DTilesRendererJS
Raycasting: Try to remove unnecessary new object / array creation
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2.5k
- Forks
- 416
- Avg merge
- 17h 52m
- Merged PRs (30d)
- 37
Description
Specifically with first hit. See here.
New arrays and objects are created every frame to sort and iterate over
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/three/raycastTraverse.js around line 57 and inspect the first-hit path, especially the arrays and objects created for sorting and iteration. Verify the raycasting behavior remains unchanged while confirming that unnecessary per-frame allocations in this path are removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, three.js
- Domain
- computer-graphics, performance
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100