NASA-AMMOS / NASA-AMMOS/3DTilesRendererJS
TilesRenderer: consider renaming "scene" to "model" across the project
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2.5k
- Forks
- 416
- Avg merge
- 17h 52m
- Merged PRs (30d)
- 37
Description
"model" is already use in multiple places to refer to geometric tile content. Other options are the following, though they are more ambiguous:
- content
- group
- object
- node
- sceneNode
Breaking change involves changing event arguments, though it can be done in a backwards compatible way
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by locating all uses of “scene,” “model,” and the related event arguments across the project, then compare the proposed terminology and compatibility implications. Done requires a decided replacement name and a documented scope for any backward-compatible event changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, three.js
- Domain
- computer-graphics
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100