NASA-AMMOS / NASA-AMMOS/3DTilesRendererJS
TilesGroup: Add boundingBox, boundingSphere fields
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2.5k
- Forks
- 416
- Avg merge
- 17h 52m
- Merged PRs (30d)
- 37
Description
Related to https://github.com/repalash/threepipe/issues/13#issuecomment-2855498366
Also revisit:
- Why do we need to check for cached bounding volume?
- Can we just expose bounding sphere on tiles renderer or group instead of having functions?
- Do we need to support changing bounding volumes?
- Why don't return the bounding volumes from the functions instead of booleans?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the linked comment on issue #13, then inspect the TilesGroup bounding-volume API and its current caching behavior. Resolve whether boundingBox and boundingSphere should be exposed as fields, whether volumes may change, and whether existing functions should return volumes; done means those API decisions are documented and implemented consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- computer-graphics
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100