NASA-AMMOS / NASA-AMMOS/3DTilesRendererJS
TopographicLineMaterial: Improvements
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2.5k
- Forks
- 416
- Avg merge
- 17h 52m
- Merged PRs (30d)
- 37
Description
- See if we can calculate height in the fragment shader based on the ellipsoid rather than interpolating in the vertex shader.
- Try scaling the values
- Consider presenting elevation to at least the granularity of the current topo lines.
Fix support for topo plugin shallow argumentsEnsure calculations for topo pixel spacing are correct (dpr isn't accounted for in margin?)Add helper function for determining transition boundaries, line stride on CPU for info display.Consider shifting the resolution value to a uniform rather than calculated.Adjust the fade limit defaults for the globe so the carto and topo lines don't overlap.Consider decreasing step size if the terrain has a low rate-of-change (fwidth of perpendicular values)?This will result in some odd spotty cases of topo lines.
Other
- Allow for more scalable precision elevation display. Ie because the elevation is clamped to 2 decimal places the precision of the displayed value diminishes further from the origin.
- Add dynamic line where the mouse is / highlight height
- Adjust fade transition distance for ortho camera (or near ortho cameras)
- Rename "topo" to "contour"
- Add middle line to improve readability.
- Remaining precision issues
- Shift values to be relative to a nearby value so the interpolation is not happening on such small fields
- Consider controllable feature for adjusting the number of segments per stride - eg use 9 at the highest level for cartographic
- Consider other options
- number of segments per emphasis line
thickness
Related to #1086
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by locating TopographicLineMaterial and reviewing related issue #1086, then narrow the remaining ideas to one agreed change with a measurable rendering or precision outcome. Done should be defined before implementation begins.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, three.js
- Domain
- computer-graphics
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100