Murmele / Murmele/Gittyup

Show full commit diff if no file is selected in double tree view

Open
#7 4 comments 6 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
2.3k
Forks
171
Avg merge
3d 19h
Merged PRs (30d)
10

Description

Hi,

I just made the jump from GitAhead to Gittyup (and to Qt 5.15 !) ; it is so nice seeing this software taking a new life !

The new filelist/diff/blame interface seems promising but currently it appears to have a bug : initially, no file/folder is selected, which means that no diff gets displayed at all. I can click on the topmost folder to see the while diff of a commit, but it will unselect when I switch to a commit that applies to a different folder. It is also not easy to show the whole diff if the commit impacts several subfolders of the repo (see screen capture).

I think a simple way to solve this would be to have the filelist have an element for the root of the repo, containing everything, and having that element activated by default.

Screenshot_20211021_215410

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the behavior in the double tree view: switch between commits with changes in different folders while no file is selected. Trace the filelist selection and diff display behavior; done means the full commit diff remains visible by default and can be shown across multiple affected subfolders.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, git
Domain
desktop, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.