Murmele / Murmele/Gittyup

Custom built version looks for files in the build directory

Open
#656 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
2.3k
Forks
171
Avg merge
3d 19h
Merged PRs (30d)
10

Description

To distribute Gittyup to my local clients, I'd like to build it myself and package it (Linux/Debian).
Building according to https://github.com/Murmele/Gittyup/blob/master/README.md seems to work. I checkout the version (currently commit 6bf49f007a9fb0577910885607833373d0552101).
From the root of the repo, I use following commands:

git submodule update
cd dep/openssl/openssl
./config -fPIC
make
cd ../../..
mkdir -p build/release
cd build/release
cmake -G Ninja -DCMAKE_BUILD_TYPE=Release ../..
ninja

This results in a version in build/release I can start.
I have following issues with this version:

  • "Help" -> "About Gittyup" displays empty text boxes for "Changelog", "Acknowledgments" and "Privacy". The console prints that the files are looked for in an absolute directory dependent from the build directory: QTextBrowser: No document for file:///<GIT ROOT FOR GITTYUP>/conf/changelog.html
  • The lua-files for the themes are also used from the git-repo: PANIC: unprotected error in call to Lua API (cannot open <GIT ROOT FOR GITTYUP>/conf/System.lua: No such file or directory)

I assume, I need to provide an additional parameter when configuring and I just can't figure out. Or there is a different solution. Anyway it would be good to include these details in README.md

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the README.md build commands and reproduce the Release build from build/release. Inspect how the build locates conf/changelog.html, conf/acknowledgments.html, conf/privacy.html, and conf/System.lua, then verify a packaged binary no longer depends on the Git repository path.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp, debian, lua
Domain
build-system, desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.