Murmele / Murmele/Gittyup

[Feature Request] Don't show Options button for Plugins without options

Open
#331 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
2.3k
Forks
171
Avg merge
3d 19h
Merged PRs (30d)
10

Description

I've been making a plugin that acts much like Comments except it won't have any options. It might help the UI to not bother showing an Options button (instead of creating the button and simply disabling it).

Edit: Around line 68 of src/dialogs/PluginsPanel.cpp, I decided to change setEnabled to setVisible. If there are no options, I don't think a button should be displayed suggesting otherwise. Makes for a cleaner and tighter UI in some cases, too.

Edit: On a side note, is it possible to grab mName and mEmail for the repo from the lua backend?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/dialogs/PluginsPanel.cpp around line 68, where the Options button is enabled or disabled. Ensure the button is not displayed for plugins without options while remaining available for plugins that have them, then verify the Plugins panel UI in both cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Feature
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.