Murmele / Murmele/Gittyup

Windows installer runs client as unexpected user after installing.

Open
#255 1 comment 1 reaction 1 assignee View on GitHub

@exactly-one-kas is already working on this.

Since Aug 31, 2022.

enhancement windows
Dominant language
C++
Stars
2.3k
Forks
171
Avg merge
3d 19h
Merged PRs (30d)
10

Description

Repro:

  1. Be logged on Windows as a regular user account that does not have elevated privileges
  2. Install Gittyup
  3. During the install, an elevation prompt opens
  4. Enter (or have someone enter) credentials for an Administrator account
  5. Installation finishes and automatically runs Gittyup when finished.
  6. Note that Gittyup is now running as the administrator user and adding using configuration in the administrative user's home directory instead of the user that asked to install the application. This not obvious to the user - as far as they are concerned, the install is finished and they never logged out of their account.

If you quit the app and run again, you will now be running as the regular user that initiated the install. However, some things that they did during the initial post-intstall session of the app might not be as expected because during that session the "home directory" was the admin user that elevated the install.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.