MuntashirAkon / MuntashirAkon/AppManager

"Redo existing backups" doesn't respect per-app settings

Open
#991 1 comment 0 reactions 0 assignees View on GitHub
Bug Feature: 1-click ops Feature: Backup Good First Issue Priority: 3 Severity: 2 Status: Accepted
Dominant language
Java
Stars
9k
Forks
518
PR merge metrics
No merged PRs in 30d

Description

### Please check before submitting an issue

- [X] I know what my device, OS and App Manager versions are
- [X] I know how to take logs
- [X] I know how to reproduce the issue which may not be specific to my device

### Describe the bug

I backup some apps with default settings:
- [x] APK files
- [x] Internal data
- [ ] External data
- [ ] OBB and Media
- [x] Cache
- [x] Extras
- [x] Rules
- [ ] Backup multiple

but I also backup some apps with APK only.

When going to top right menu > 1-Click Ops > Back up > Redo existing backups > selecting desired apps > Back up, we're asked to choose what to back up. It defaults to the above list.

As a result, all the apps selected are backed up with these settings, which isn't what "redo existing backups" should be doing in my opinion. Applications already backed up with APK only should be backed up again with APK only.

### To Reproduce

1. Backup an app with default settings:
- [x] APK files
- [x] Internal data
- [ ] External data
- [ ] OBB and Media
- [x] Cache
- [x] Extras
- [x] Rules
- [ ] Backup multiple
2. Backup another one with APK only:
- [x] APK files
3. Go to top right menu
4. 1-Click Ops
5. Back up
6. Redo existing backups
7. Select both apps previously backed up
8. Back up
9. AppManager then asks what to backup
10. Choose default settings
11. The app which was backed up with APK only is now backed up with APK+data (settings chosen before)

### Expected behavior

"Redo existing backups" should, well... redo backups.

Ideally, the screen where we're asked to choose what to backup wouldn't exist (AppManager should remember the settings for each app during the initial backup).

### Screenshots

_No response_

### Logs

_No response_

### Device info

- Device: OnePlus 7 Pro
- OS Version: 13
- App Manager Version: 3.0.4 (416)
- Mode: Root

### Additional context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.