MozillaSecurity / MozillaSecurity/FuzzManager

[CrashManager] No signature suggestion causes 500 error

Open Beginner friendly
#818 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug crashmanager
Dominant language
Python
Stars
208
Forks
48
Avg merge
23h 5m
Merged PRs (30d)
2

Description

Creating a bucket from a "No crash detected" CrashEntry results in a 500 server error.

Traceback (most recent call last):
  File "/srv/venv/lib/python3.8/site-packages/django/core/handlers/base.py", line 113, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/srv/FuzzManager/server/crashmanager/views.py", line 396, in newSignature
    'proposedSig': json.loads(proposedSignature),
  File "/usr/lib/python3.8/json/__init__.py", line 357, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.8/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.8/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

We should handle this case and show the new signature form with no suggestion.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in crashmanager/views.py at newSignature, especially the proposedSignature handling shown in the traceback. Reproduce bucket creation from a "No crash detected" CrashEntry, then verify the request no longer returns a 500 and instead displays the new signature form without a suggestion.

Written by the indexing model from the issue text.

Assessment

Tech stack
django, python
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.