MorphiaOrg / MorphiaOrg/morphia

Update DiscriminatorFunction API to return the value rather than set it directly

Open
#3,140 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Breaking enhancement rewritable
Dominant language
Java
Stars
1.7k
Forks
449
Avg merge
7m
Merged PRs (30d)
10

Description

This change simplifies the critter implementation of discriminator configuration and aligns this API with NamingStrategy, e.g.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating DiscriminatorFunction and comparing its API with NamingStrategy, then inspect the critter implementation referenced in the issue. Update the discriminator configuration flow so the function returns the value rather than setting it directly, and verify that existing discriminator behavior remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, mongodb
Domain
databases
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.