MongoEngine / MongoEngine/mongoengine

Can't save new key in DynamicField

Open
#889 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
4.3k
Forks
1.2k
Avg merge
4h 41m
Merged PRs (30d)
11

Description

Hi, i get some trouble with using DynamicField with dict as default value, there example of my code

class AuthorBooks(Document):
    author = StringField()
    comments = DynamicField(default=dict)

a = AuthorBooks()
a.author = "Andrew"
a.comments['booklist'] = ['Moby Dick']
a.save()
a.save()
a.comments['description'] = 'whale'
a.save()

In mongo we got only

{
    "_id" : ObjectId("54eae2822796251b080e3219"),
    "author" : "Andrew",
    "comments" : {
        "booklist" : [
            "Moby Dick"
        ]
    }
}

if change object id by copy.copy() save correclty

class AuthorBooks(Document):
    author = StringField()
    comments = DynamicField(default=dict)


a = AuthorBooks()
a.author = "Andrew"
a.comments['booklist'] = ['Moby Dick']
a.save()
comments = copy.copy(a.comments)
comments['description'] = 'whale'
a.comments = comments
a.save()

Mongo

{
    "_id" : ObjectId("54eae2822796251b080e3219"),
    "author" : "Andrew",
    "comments" : {
        "booklist" : [
            "Moby Dick"
        ],
        "description" : "whale"
    }
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with DynamicField and the change-tracking path, then reproduce the reported sequence of mutating comments, saving, mutating it again, and saving once more. Done means the second in-place mutation, including the description key, is persisted without copying and reassigning the dictionary.

Written by the indexing model from the issue text.

Assessment

Tech stack
mongodb, python
Domain
backend, databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.