MongoEngine / MongoEngine/mongoengine

EmbeddedDocumentList in nested embededded document save() does not find the parent document

Open
#2,695 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
4.3k
Forks
1.2k
Avg merge
4h 41m
Merged PRs (30d)
11

Description

save() not working in an EmbeddedDocumentList in nested embedded document, as _instance is an EmbeddedDocument instead of Document

Reproducer:

class TestK2(EmbeddedDocument):
  values = EmbeddedDocumentListField(StringField, default=[])

class TestK1(EmbeddedDocument): 
  k2 = EmbeddedDocumentField(TestK2)

class Main(Document):
  part = EmbeddedDocumentField(TestK1)

def main(): 
  main = Part()
  main.part.k1.k2.values.save()  # AttributeError: TestK1 has no attribute 'save'

I would assume that nested EmbeddedDocuments should have _instance pointing to the Document instance and _parent pointing to the parent doc (embedded or actual document)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the reproducer and the EmbeddedDocumentList save() entry point, then trace how _instance and _parent are assigned through the nested TestK1 and TestK2 embedded documents. Done means calling save() on the nested values list finds the Main Document rather than treating TestK1 as the document, without the reported AttributeError.

Written by the indexing model from the issue text.

Assessment

Tech stack
mongodb, python
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.