MongoEngine / MongoEngine/mongoengine
Cascade deletion won't delete GridFS file blocks used by FileField
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 4.3k
- Forks
- 1.2k
- Avg merge
- 4h 41m
- Merged PRs (30d)
- 11
Description
GridFS data blocks delete by:
https://github.com/MongoEngine/mongoengine/blob/92f6fce77d12f930333bd8980fa611627d3a8d1b/mongoengine/document.py#L642-L644
then
https://github.com/MongoEngine/mongoengine/blob/92f6fce77d12f930333bd8980fa611627d3a8d1b/mongoengine/fields.py#L1839-L1844
So calling Document.delete() won't ran into this issue, but cascade delete will, because:
https://github.com/MongoEngine/mongoengine/blob/161493c0d24c4f23d4d576f7171e78f0e62cdd70/mongoengine/queryset/base.py#L505-L509
this will call pymongo's delete directly, which will bypass file block delete logic that i referenced above
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing cascade deletion in mongoengine/queryset/base.py around lines 505-509, then compare it with Document.delete() in document.py and FileField handling in fields.py around lines 1839-1844. Reproduce cascade deletion for a document with a FileField and verify that the associated GridFS file blocks are deleted as well.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- mongodb, python
- Domain
- database
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100