MongoEngine / MongoEngine/mongoengine
Mongoengine runs validate also on non changed fields before saving.
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 4.3k
- Forks
- 1.2k
- Avg merge
- 4h 41m
- Merged PRs (30d)
- 11
Description
class User(Resource):
state = IntField(required=True)
name = SmallStringField(required=True)
u = User()
u.state = 1
u.name = "Tamer"
u.save()
u1 = User.objects.only('name').first()
u1.name = "Radian"
u1.save() # Fails because state is required
Mongoengine runs validate on all fields before save, even if there they are not changed. Which cases the above problem. I suggest save should validate changed fields only in case of partial documents.
I am running the stable Mongoengine version from pip.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the partial-document example with User.objects.only('name'), then trace the save and validation path for the User model. Confirm the expected behavior by ensuring changing and saving name does not fail because the unloaded required state field is absent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- mongodb, python
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100