MongoEngine / MongoEngine/mongoengine
Performing sum() on DecimalField
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 4.3k
- Forks
- 1.2k
- Avg merge
- 4h 41m
- Merged PRs (30d)
- 11
Description
Looks like .sum("some_decimal_field") returns float.
I suggest returning decimal.Decimal in that case, as it is more consistent.
This will break backward compatibility, so I'm in doubt if this change is necessary.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the implementation of .sum("some_decimal_field") and the DecimalField handling in MongoEngine, then inspect any related tests. Compare the current float result with the expected decimal.Decimal behavior and document or test the backward-compatibility decision before considering the issue done.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- mongodb, python
- Domain
- database
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100