MongoEngine / MongoEngine/mongoengine
Should max_time_ms apply to aggregate functions?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 4.3k
- Forks
- 1.2k
- Avg merge
- 4h 41m
- Merged PRs (30d)
- 11
Description
From the documentation I would have thought that max_time_ms will apply to calls to aggregate.
But in reality, you need to pass the value as a keyword argument to aggregate: e.g. aggregate(*pipeline, maxTimeMS=1000)
I could do a PR for the QuerySet to do this automatically (if _max_time_ms is not None) in aggregate. Would that be accepted? Or is there a reason why the aggregate calls do not honor max_time_ms?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading QuerySet.max_time_ms and QuerySet.aggregate, along with the linked API documentation, to compare the documented behavior with the current aggregate call. Check how MongoDB receives maxTimeMS and add focused coverage if the project has an appropriate queryset test location; done means aggregate honors the configured timeout consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- mongodb, python
- Domain
- database
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100