Suggested Fix: Replace the event "keyup" with "keydown" for Compatibility with Chinese IMEs
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- frontend
Research direction
Start by searching the JavaScript sources for keyup handlers used by the AlertifyJS prompt and inspect how Enter is handled during form submission. Replace the relevant event usage with keydown as described, then verify that Chinese IME character selection does not submit the prompt while normal keyboard interaction remains usable.
Written by the indexing model from the issue text.
Description
When typing with a Chinese input method editor (IME) on a computer, users select characters using the arrow keys and the enter key. However, in the AlertifyJS prompt window, pressing enter to select a character triggers the form submission. This causes significant inconvenience for users, as shown in the video.
I subsequently replaced all instances of the “keyup” event in the JS file with “keydown,” which perfectly resolved the issue without affecting usability. This modified version has already been deployed to the website “Hearty Journal”. Therefore, I suggest that the author consider making this adjustment as well.
https://github.com/user-attachments/assets/110837f6-3a80-448a-9a09-d0b24f9b373a
- Dominant language
- JavaScript
- Stars
- 2.1k
- Forks
- 294
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MohammadYounes/AlertifyJS
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
MohammadYounes/AlertifyJS#278 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
MohammadYounes/AlertifyJS#277 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
MohammadYounes/AlertifyJS#275 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 50/100
MohammadYounes/AlertifyJS#274 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
MohammadYounes/AlertifyJS#265 ·
All issues in MohammadYounes/AlertifyJS
Similar issues
-
code-quality refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
github/gh-aw-firewall#8816 ·
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·
-
optimization optimization:agents-md-curator
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
githubnext/gh-aw-cao#13143 ·
-
status: needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100