MohammadYounes / MohammadYounes/AlertifyJS
Brave blocks Alertify
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2.1k
- Forks
- 294
- PR merge metrics
- No merged PRs in 30d
Description
With the Brave new feature to prevent cookie windows, alertify (notifier) no longer works. To test I invite you to follow the procedure described at https://brave.com/privacy-updates/21-blocking-cookie-notices/.
By modifying the defined classes it is possible to circumvent this, except that alertify does not take into account the modification of the notify classes defined in configuration. I looked a bit in the code and indeed it uses the classes defined in the defaults object.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the notifier configuration and the defaults object that defines its notify classes. Reproduce the Brave cookie-window blocking procedure, then trace whether configured notify classes are applied instead of the defaults; done means Alertify notifications work with the customized classes in Brave.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100