MohammadYounes / MohammadYounes/AlertifyJS
Set `preventBodyShift` to true in the examples
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2.1k
- Forks
- 294
- PR merge metrics
- No merged PRs in 30d
Description
Running the examples in https://alertifyjs.com/ cause the body to shift because the vertical scrollbar disappears. I was about to open an issue about this but I saw #167. So there is already a way to do it, which seems to be the preventBodyShift option.
This issue is to suggest that preventBodyShift is set on the examples in https://alertifyjs.com/ because it is a bit discouraging to see a body shift like this in the first example.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the examples on alertifyjs.com and locate where their AlertifyJS options are configured. Set preventBodyShift to true for the examples, then verify that opening dialogs no longer causes the page body to shift as the scrollbar disappears.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100