MohammadYounes / MohammadYounes/AlertifyJS
iframe content will reload
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- JavaScript
- Stars
- 2.1k
- Forks
- 294
- PR merge metrics
- No merged PRs in 30d
Description
If the dialog content include iframe tag, when switch to another one, the target dialog content will reload.
alertify.dialog('demo',function(){
return {
main:function(content){
this.setContent(content);
this.resizeTo(400,500);
},
setup:function(){
return {options:{modal:false,resizable:true,padding:false}};
}
};
},true,'alert');
alertify.demo('<iframe src="https://time.is" style="width:98%;height:98%;"></iframe>').moveTo(10,10);
alertify.demo('<iframe src="https://time.is" style="width:98%;height:98%;"></iframe>').moveTo(450,10);
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with the two alertify.demo calls shown in the report, switching between dialogs that contain the time.is iframe. Then trace the dialog content-switching path and determine why the iframe reloads; done means switching dialogs no longer reloads existing iframe content, with regression coverage for this scenario.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100