Moerill / Moerill/fvtt-pointer

[BUG] Keybindings stuck on last settings before updating to V10 Foundry

Open
#39 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
5
Forks
19
PR merge metrics
No merged PRs in 30d

Description

Using the template
Choose a fitting title to your issue.
Please go through each section, adding as much detailed information as possible and remove the default text. If a section is completly irrelevant for some reason, delete it completly.
Also ideally be somewhat responsive in this issues thread so you can answer possible questions i have.

Describe the bug
A clear and concise description of what the bug is.
Also post console errors (F12 for most browsers) here that occur.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Settings and Designs Studio for PnP
  2. Click on General
  3. Click on any of the settings to change them, input any key, then attempt to click away or change something else
  4. Keybinding reverts back to original setting before the change

Expected behavior
A permanent change in what binds the program uses

Module incompatibilities
It still does not change the hotkey with no other modules on (Besides the compatibility checker, which I doubt has any influence on it.)
The find the culprit module may prove to be useful here.

Screenshots/GIFs/Videos
image_2022-09-09_015735771
This is the error that shows up when the module is on

A picture is worth a thousand words.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • FVTT Version [e.g. 0.6.6]
  • Module version [e.g. 0.1.0]

Additional context
Add any other context about the problem here.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the problem in Settings and Designs Studio for PnP, under General, with other modules disabled. Check the console error shown in the issue and compare changing a keybinding with clicking away or editing another setting; done means the new keybinding remains active after the change.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.