Moerill / Moerill/fvtt-pointer

[BUG] Unable to edit name of pointer/ping

Open
#37 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
5
Forks
19
PR merge metrics
No merged PRs in 30d

Description

When I try to edit the name of the pointer/ping, the name is not changed.

In the console, you can see that each character is added to the beginning of the name in turn, but only the last character gets added to the front of the name and the rest of the name remains the same.

This also makes it difficult to Add New pointer/pings because it won't take a new name.

I was able to work around this by typing in single character names, although the text box showed the New name or maybe one of the other names.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Configure Settings -> PnP Settings and Design Studio'
  2. Click on 'Choose your pointer'
  3. Select a pointer name, or Add New pointer
  4. Type a new name.
  5. Nothing happens or a character ends up at the front of the string.
  6. In the console, you can see the name of the object been modified and each character typed added to the front of the string.

Expected behavior
The new name should be be displayed and updated in the list.

Module incompatibilities
Same problem when I disabled all modules

Screenshots/GIFs/Videos
If applicable, add screenshots to help explain your problem.

A picture is worth a thousand words.

Desktop (please complete the following information):

  • OS: MacOS 12.3
  • Browser: Chrome
  • FVTT Version: v9.255
  • Module version: 2.3.4

Additional context
Add any other context about the problem here.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue through Configure Settings -> PnP Settings and Design Studio, then inspect the console output while editing or adding a pointer name. Trace where each typed character updates the pointer object and how the name list is refreshed. Done means multi-character names are displayed and updated correctly for both existing and newly added pointer/pings.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.