Moerill / Moerill/fvtt-pointer

[BUG] Foundry's interface stop responding after trying to reassign keybindings in v9

Open
#33 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
5
Forks
19
PR merge metrics
No merged PRs in 30d

Description

Reassigning keys in V9 hangs FoundryVTT

Describe the bug
After installing this module, when I try to reassign the keys for Pointer and Click, Foundry VTT stops responding, to the point that I have to forcefully close it. What stops responding is the interface. If I happen to have the Dev Tools open (via F12) before FoundryVTT hangs, the Dev Tools are operable (but no error is shown in the console).

This happens on an almost empty Alien RPG world, and with no other modules enabled.

To Reproduce

  1. Enable PnP - Pointers and Pings! in some game world.
  2. Click Configure Settings.
  3. Click Module Settings.
  4. Search the PnP options and click on Settings and Design Studio.
  5. Click on General.
  6. Click on the input box for Pointer and type P.
  7. Click on the input box for Ping and type G.
  8. It should've hanged by now. If not, repeat steps 6 and 7 a few times with different keys.

Expected behavior
Keybindings changed and FoundryVTT responsive.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: not applicable, I'm directly using the Electron instance
  • FVTT Version: 9.238
  • Module version: 2.3.4

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the hang through Configure Settings, Module Settings, Settings and Design Studio, General, and repeated Pointer and Ping key changes in Foundry VTT v9.238 with module version 2.3.4. Use the Electron instance and Dev Tools while testing, then verify that keybindings change without the interface becoming unresponsive.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.