ModShardTeam / ModShardTeam/ModShardLauncher

[ENHANCEMENT] Localizable Tables

Open
#69 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

priority:medium type:enhancement
Dominant language
C#
Stars
55
Forks
13
PR merge metrics
No merged PRs in 30d

Description

Describe the problem which requires a new feature.

Quite a few localizable tables are still missing from MSL.
As it is, they still have to be implemented by hand, which is inconvenient.

Describe the solution you'd like

The following tables should be implemented :

ASAP, as requested by iamoyoman for UI+ on discord :

  • gml_GlobalScript_table_text
  • gml_GlobalScript_table_weapons_text

When possible :

  • gml_GlobalScript_table_stats
  • gml_GlobalScript_table_keyboard_keys
  • gml_GlobalScript_table_log_text
  • gml_GlobalScript_table_hints_text
  • gml_GlobalScript_table_dialogs
  • gml_GlobalScript_table_NPC_names
  • gml_GlobalScript_table_Miniboss_type
  • gml_GlobalScript_table_Books
  • gml_GlobalScript_table_location_titles
  • gml_GlobalScript_table_Modifiers
  • gml_GlobalScript_table_speech
  • gml_GlobalScript_table_Dungeons_name
  • gml_GlobalScript_table_Potions_text
  • gml_GlobalScript_table_enemy_balance
  • gml_GlobalScript_table_Miniboss
  • gml_GlobalScript_table_color_hovers_text
  • gml_GlobalScript_table_all_attribute
  • gml_GlobalScript_table_NPC_Lines
  • gml_GlobalScript_table_char_lines
  • gml_GlobalScript_table_consumables
  • gml_GlobalScript_table_Quests_text
  • gml_GlobalScript_table_Contracts_text
  • gml_GlobalScript_table_enemy_text
  • gml_GlobalScript_table_Curse
  • gml_GlobalScript_table_credits
  • gml_GlobalScript_table_credits_backers

Describe alternatives you've considered if any

N/A

Additional context

The non-localizable tables are already done (see #43)
Part of this work should be easier as LocalizationUtils.cs already has a system in place which should be usable.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading LocalizationUtils.cs and compare its existing system with the completed localizable tables listed in the issue. Use #43 as the reference for the already completed non-localizable tables. Done means implementing the remaining unchecked tables, including gml_GlobalScript_table_text, and verifying that the localization system handles them.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
localization, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.