ModShardTeam / ModShardTeam/ModShardLauncher
[BUG] Bug report
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 55
- Forks
- 13
- PR merge metrics
- No merged PRs in 30d
Description
Hi the code at https://github.com/ModShardTeam/ModShardLauncher/blob/main/FileReader.cs#L150 to check for version number is buggy:
If the number of textures was 0x30-0x39, the version checking will eat the texture number (at https://github.com/ModShardTeam/ModShardLauncher/blob/main/FileReader.cs#L171) and resulting in texture count corrupted, so the whole loading process will throw error "In FileReader.Read cannot read {0} bytes in the mod {1}"
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in FileReader.cs at lines 150 and 171, then reproduce the loader failure with a texture count from 0x30–0x39. Trace how version checking affects the texture count and verify that loading completes without the reported read error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100