MobileNativeFoundation / MobileNativeFoundation/rules_xcodeproj

Write more tests for `pbxnativetargets` generator

Open
#2,817 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

cleanup
Dominant language
Swift
Stars
626
Forks
124
PR merge metrics
No merged PRs in 30d

Description

In order to get incremental generation mode into a proper build for additional widespread testing, I deferred some tests:

  • Write CalculatePlatformVariants tests
  • Write CreateBuildPhases tests
  • Write CreateProductBuildFileObject tests
  • Write CreateProductObject tests
  • Write CreateTarget tests
  • Write CreateXcodeConfigurations tests
  • Write TargetArguments tests
  • Write EXCLUDED_SOURCE_FILE_NAMES tests
  • Extract and test consolidatePaths()

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the pbxnativetargets generator and its existing tests, then review the deferred checklist in the issue. Start with the listed functions, including CalculatePlatformVariants, CreateBuildPhases, CreateTarget, and consolidatePaths(). Done means adding coverage for the listed generator behavior and extracting and testing consolidatePaths().

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
build-system, testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.