MobileNativeFoundation / MobileNativeFoundation/rules_xcodeproj

Bug: Xcode Previews fail to find transitive frameworks when using `--define=apple.experimental.tree_artifact_outputs=0`

Open
#2,641 1 comment 0 reactions 1 assignee View on GitHub

@brentleyjones is already working on this.

Since Sep 29, 2023.

bug
Dominant language
Swift
Stars
626
Forks
124
PR merge metrics
No merged PRs in 30d

Description

Description

We don't unarchive transitive frameworks when copying them over to SwiftUIPreviewsFrameworks. This is an issue when using --define=apple.experimental.tree_artifact_outputs=0.

Reproduction steps

In examples/integration (which currently sets --define=apple.experimental.tree_artifact_outputs=0) try to use the UI Xcode Preview.

Expected behavior

We shouldn't unarchive artifacts in copy_outputs.sh. Instead we should generate an unarchiving action, and depend on that instead in the output groups. Then, regardless of what apple.experimental.tree_artifact_outputs is set to, we will always have a tree artifact.

rules_xcodeproj version

1.11.0

Xcode version

15.0

Bazel version

6.4.0rc1

rules_apple version

No response

rules_swift version

No response

Additional information

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.