MobileNativeFoundation / MobileNativeFoundation/rules_xcodeproj

Bug: `_FORTIFY_SOURCE=2` isn't handled correctly

Open
#2,080 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Swift
Stars
626
Forks
124
PR merge metrics
No merged PRs in 30d

Description

Description

https://github.com/MobileNativeFoundation/rules_xcodeproj/blob/4b1ef3c7f950f5b7daa4bd22f77860e89dab0571/xcodeproj/internal/opts.bzl#L858-L859

We need to check for _FORTIFY_SOURCE= that isn't 0 basically.

Reproduction steps

N/A

Expected behavior

N/A

rules_xcodeproj version

4b1ef3c7f950f5b7daa4bd22f77860e89dab0571

Xcode version

N/A

Bazel version

N/A

rules_apple version

No response

rules_swift version

No response

Additional information

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting opts.bzl at lines 858-859, which the issue identifies as the handling point for _FORTIFY_SOURCE. Verify the condition distinguishes a value of 0 from other values, then confirm the updated handling with the project's relevant checks; done means _FORTIFY_SOURCE=2 is handled correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.